search

postlight / parser-api

🚀 A drop-in replacement for the Postlight Parser API.
https://reader.postlight.com/
Apache License 2.0
282 stars 113 forks source link

chore: update node version #33

Closed WajeehZantout closed 4 years ago

WajeehZantout commented 4 years ago

This PR updates node runtime version to the latest stable version: v12.x

For reference: https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

WajeehZantout commented 4 years ago

@adampash after the upgrade, I was getting the following warnings in the console when trying to build the project:

WARNING in ./node_modules/parse5/lib/index.js 55:23-49
Critical dependency: the request of a dependency is an expression
 @ ./node_modules/jsdom/lib/jsdom/browser/domtohtml.js
 @ ./node_modules/jsdom/lib/api.js
 @ ./node_modules/turndown/lib/turndown.es.js
 @ ./node_modules/@postlight/mercury-parser/dist/mercury.js
 @ ./src/mercury-parser.js

WARNING in ./node_modules/jsdom/lib/jsdom/utils.js 186:21-40
Critical dependency: the request of a dependency is an expression
 @ ./node_modules/jsdom/lib/jsdom/living/node-filter.js
 @ ./node_modules/jsdom/lib/jsdom/living/index.js
 @ ./node_modules/jsdom/lib/jsdom/browser/Window.js
 @ ./node_modules/jsdom/lib/api.js
 @ ./node_modules/turndown/lib/turndown.es.js
 @ ./node_modules/@postlight/mercury-parser/dist/mercury.js
 @ ./src/mercury-parser.js

WARNING in ./node_modules/jsdom/node_modules/ws/lib/buffer-util.js
Module not found: Error: Can't resolve 'bufferutil' in '/node_modules/jsdom/node_modules/ws/lib'
 @ ./node_modules/jsdom/node_modules/ws/lib/buffer-util.js
 @ ./node_modules/jsdom/node_modules/ws/lib/receiver.js
 @ ./node_modules/jsdom/node_modules/ws/index.js
 @ ./node_modules/jsdom/lib/jsdom/living/websockets/WebSocket-impl.js
 @ ./node_modules/jsdom/lib/jsdom/browser/Window.js
 @ ./node_modules/jsdom/lib/api.js
 @ ./node_modules/turndown/lib/turndown.es.js
 @ ./node_modules/@postlight/mercury-parser/dist/mercury.js
 @ ./src/mercury-parser.js

WARNING in ./node_modules/jsdom/node_modules/ws/lib/validation.js
Module not found: Error: Can't resolve 'utf-8-validate' in '/node_modules/jsdom/node_modules/ws/lib'
 @ ./node_modules/jsdom/node_modules/ws/lib/validation.js
 @ ./node_modules/jsdom/node_modules/ws/lib/receiver.js
 @ ./node_modules/jsdom/node_modules/ws/index.js
 @ ./node_modules/jsdom/lib/jsdom/living/websockets/WebSocket-impl.js
 @ ./node_modules/jsdom/lib/jsdom/browser/Window.js
 @ ./node_modules/jsdom/lib/api.js
 @ ./node_modules/turndown/lib/turndown.es.js
 @ ./node_modules/@postlight/mercury-parser/dist/mercury.js
 @ ./src/mercury-parser.js

Adding nodeExternals fixed them