search

postlight / parser

📜 Extract meaningful content from the chaos of a web page
https://reader.postlight.com
Apache License 2.0
5.4k stars 442 forks source link

chore: update node version in .nvmrc & CONTRIBUTING.md #599

Closed PeterDaveHello closed 2 years ago

PeterDaveHello commented 3 years ago

Ref: #579, a5a066c69dc422e0abd3127f281c119a8ddfa241

PeterDaveHello commented 3 years ago

Hello @JadTermsani, do you have a minute to review this PR? Thank you ;)

JadTermsani commented 3 years ago

@PeterDaveHello I think it's better to specify version 12.8.1 that we're using

PeterDaveHello commented 3 years ago

@JadTermsani, thanks for your review, and commit revised as suggested.

BTW, just thought maybe not stick to the patch version will keep the things more up-to-date as by following semantic versioning, stick to the major version shouldn't break things in most cases?

JadTermsani commented 3 years ago

@PeterDaveHello agreed. But thought of keeping everything aligned. ty!