search

postlight / parser

📜 Extract meaningful content from the chaos of a web page
https://reader.postlight.com
Apache License 2.0
5.4k stars 442 forks source link

TypeScript conversion #634

Closed agg23 closed 2 years ago

agg23 commented 2 years ago

Converts the codebase into TypeScript for a more modern development pipeline and allowing for safer modifications. Includes updates to the build pipelines and tests (though Karma tests are currently not operational).

As is standard with TypeScript, most imports and exports are switched to named exports, rather than using default exports.

agg23 commented 2 years ago

Looks like the CircleCI docker image needs an updated version of Node to build.

johnholdun commented 2 years ago

Hi there! Thanks for this heroic effort. Unfortunately, the remaining work and ongoing maintenance required in converting this repo to Typescript is not something we have the capacity for right now, so I'm going to close this PR. If you feel really strongly about us proceeding, please feel free to open a new Issue and we can discuss it there.

Thanks again!