search

postlight / parser

📜 Extract meaningful content from the chaos of a web page
https://reader.postlight.com
Apache License 2.0
5.35k stars 436 forks source link

adjust postlight insights custom selectors #707

Closed austinmbrown closed 1 year ago

austinmbrown commented 1 year ago

This PR addresses this issue by adjusting the selectors in Postlight.com's custom selector. I had to expand the main content's selector and then exclude a few elements from within it. That way the hero image gets pulled in as part of the content and can be displayed by the Reader.

Note that the Parser does successfully select the hero image and emit it to the Reader as the lead_image_url, but that the Reader does not make use of that field for anything. So there might be a bigger design/product question to explore there. This is a reasonable fix in the meantime.

austinmbrown commented 1 year ago

What's up with CI on this project? It failed on my last PR too...

austinmbrown commented 1 year ago

(I'm not authorized to merge, BTW.)

johnholdun commented 1 year ago

Yeah, something went wrong with the CircleCI config. I opened an issue to track it; doesn't seem related to your work specifically. I will merge!