postlight / parser

📜 Extract meaningful content from the chaos of a web page

https://reader.postlight.com

Apache License 2.0

5.42k stars 445 forks source link

fix: replace moment with dayjs #737

Open touchRED opened 1 year ago

touchRED commented 1 year ago

731

Replaces Moment with DayJS, a 2kb library with an almost identical API.

Note:

DayJS doesn't ship with an equivalent to Moment's parseFormat method used here. I'm not quite sure how long it could take to recreate this method, and I don't believe the moment-parseformat plugin can function without Moment installed. Thoughts?

johnholdun commented 1 year ago

Nice! There are tons of examples of real-world timestamps in the fixture files which we can test here as well. I think the best we can aim for here is an equal success rate against all those timestamps to what we were getting with moment.

touchRED commented 1 year ago

@johnholdun yep i'm running through all the tests now, realized moment was called in more of those than I expected. More to come!

touchRED commented 1 year ago

@johnholdun clearly the updates we spoke about last week took significantly longer than I expected! Now that test-node is passing I'm going to clean things up, leave comments, etc. Question for you: in order to get test-web to pass, do I need to run yarn release and push up new dist files?

appinteractive commented 7 months ago

Hey is this issue still be worked on?