postlund / pyatv

A client library for Apple TV and AirPlay devices
https://pyatv.dev
MIT License
882 stars 96 forks source link

airplay: Handle Access Control Type #2118

Closed postlund closed 1 year ago

postlund commented 1 year ago

The Access Control Type (ACT) tells us more regarding if pairing if required or not. It is however not known what the different values are, but "2" corresponds to access setting "Current User", which is not supported by pyatv. So filter that and return Unsupported as pairing requirement.

Relates to #2105

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% :warning:

Comparison is base (42130e1) 88.68% compared to head (5b75ac4) 88.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2118 +/- ## ========================================== - Coverage 88.68% 88.66% -0.03% ========================================== Files 162 162 Lines 10969 10973 +4 ========================================== + Hits 9728 9729 +1 - Misses 1241 1244 +3 ``` | [Files Changed](https://app.codecov.io/gh/postlund/pyatv/pull/2118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+St%C3%A5hl) | Coverage Δ | | |---|---|---| | [pyatv/protocols/airplay/utils.py](https://app.codecov.io/gh/postlund/pyatv/pull/2118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+St%C3%A5hl#diff-cHlhdHYvcHJvdG9jb2xzL2FpcnBsYXkvdXRpbHMucHk=) | `87.85% <100.00%> (+0.17%)` | :arrow_up: | | [pyatv/protocols/raop/\_\_init\_\_.py](https://app.codecov.io/gh/postlund/pyatv/pull/2118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+St%C3%A5hl#diff-cHlhdHYvcHJvdG9jb2xzL3Jhb3AvX19pbml0X18ucHk=) | `97.02% <100.00%> (+0.02%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/postlund/pyatv/pull/2118/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+St%C3%A5hl)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.