Closed maxileith closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
427c362
) 88.95% compared to head (a3a4c65
) 88.80%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have updated the pull request to include the MAC-Address in the device infos since I noticed that this is available on the atv object anyways
Hi @postlund ,
Can you do a ruff estimation on when you will have the time to look at the PR? I don't want to stress, I am just curious and would like to evaluate wether I will wait for the PR or do a workaround 😬
@maxileith Sorry about the delay, I will try to get around doing that this week!
Sorry for not getting back sooner on this, but it looks good to me! 👍 I'll see if there's anything else to include, otherwise I can make a minor release soon with this change.
@postlund don't worry about the late response. We all have private lifes besides our passion for FOSS 😉
Hi @postlund ,
for the use-case I am currently working on, I use Airplay MAC-Adresses as an identifier https://github.com/maxileith/homebridge-appletv-enhanced/issues/20. Therefore, I always need to get the MAC-Address as an identifier from
atvscript
. However, currently the returned identifier fromatvscript scan
is not always the MAC-Address. Therefore, I would suggest to add an attributeall_identifieres
to the output json. By not touchingidentifier
of the output json, backward compatability is given.I'd love to hear your thoughts on that.