postlund
commented
3 years ago Will try to figure this out and place some mental notes here. Using the same use case as above, this is what happens to AirPlay in short form (I have removed supported commands):
[setNowPlayingClientMessage] {
client {
processIdentifier: 175
bundleIdentifier: "com.apple.TVAirPlay"
}
[updateClientMessage] {
client {
processIdentifier: 175
bundleIdentifier: "com.apple.TVAirPlay"
processUserIdentifier: 501
displayName: "AirPlay"
}
}
[setNowPlayingPlayerMessage] {
playerPath {
origin {
displayName: "Vardagsrum"
identifier: 1280262988
}
client {
processIdentifier: 175
bundleIdentifier: "com.apple.TVAirPlay"
}
player {
identifier: "avkit-6E99D9C8-2750-4D34-A411-28263FFD4E9C"
displayName: "player-7"
}
}
}
[setStateMessage] {
supportedCommands {
...
}
playbackQueue {
location: 0
contentItems {
identifier: "F326D3FF-BDE3-43D1-8AF8-53D7DB94F43E"
}
}
displayName: "AirPlay"
playbackState: Paused
playbackQueueCapabilities {
requestByRange: true
requestByIdentifiers: true
}
playerPath {
origin {
displayName: "Vardagsrum"
identifier: 1280262988
}
client {
processIdentifier: 175
bundleIdentifier: "com.apple.TVAirPlay"
}
player {
identifier: "MediaRemote-DefaultPlayer"
displayName: "Default Player"
}
}
playbackStateTimestamp: 630025231.464317
}
[setStateMessage] {
supportedCommands {
...
}
playbackQueue {
location: 0
contentItems {
identifier: "com.apple.avkit.175.da6aee3f"
metadata {
title: ""
duration: 596.4733333333334
artworkAvailable: false
infoAvailable: false
languageOptionsAvailable: true
numberOfSections: 0
elapsedTime: 0.0
isAlwaysLive: false
playbackRate: 0.0
mediaType: Video
nowPlayingInfoData: "bplist00\324\001\002\003\004\005\006\007\nX$versionY$archiverT$topX$objects\022\000\001\206\240_\020\017NSKeyedArchive...
elapsedTimeTimestamp: 630591678.821276
inferredTimestamp: 630591678.809078
legacyUniqueIdentifier: -630526401
}
}
requestId: "PlaybackQueueInvalidation-889FE028-BFB8-4F9E-B1F7-EFB0070D74D8"
resolvedPlayerPath {
origin {
displayName: "Vardagsrum"
identifier: 1280262988
}
client {
processIdentifier: 175
bundleIdentifier: "com.apple.TVAirPlay"
}
player {
identifier: "avkit-6E99D9C8-2750-4D34-A411-28263FFD4E9C"
displayName: "player-7"
5: 751619276821
}
}
}
displayName: "AirPlay"
playbackState: Paused
playbackQueueCapabilities {
requestByRange: true
}
playerPath {
origin {
displayName: "Vardagsrum"
identifier: 1280262988
}
client {
processIdentifier: 175
bundleIdentifier: "com.apple.TVAirPlay"
}
player {
identifier: "avkit-6E99D9C8-2750-4D34-A411-28263FFD4E9C"
displayName: "player-7"
}
}
playbackStateTimestamp: 630591678.687111
}
1: 58
62 {
1 { <-- likely a PlayerPath
1 {
2: "Vardagsrum"
3: 1280262988
}
2 {
1: 175
2: "com.apple.TVAirPlay"
}
3 {
1: "avkit-6E99D9C8-2750-4D34-A411-28263FFD4E9C"
2: "player-7"
5: 751619276821
}
}
}When stopping the stream, this happens:
[setStateMessage] {
playbackQueueCapabilities {
}
playerPath {
origin {
displayName: "Vardagsrum"
identifier: 1280262988
}
client {
processIdentifier: 175
bundleIdentifier: "com.apple.TVAirPlay"
}
player {
identifier: "avkit-6E99D9C8-2750-4D34-A411-28263FFD4E9C"
displayName: "player-7"
}
}
}
[removePlayerMessage] {
playerPath {
origin {
displayName: "Vardagsrum"
identifier: 1280262988
}
client {
processIdentifier: 175
bundleIdentifier: "com.apple.TVAirPlay"
}
player {
identifier: "avkit-6E99D9C8-2750-4D34-A411-28263FFD4E9C"
displayName: "player-7"
}
}
}
[setNowPlayingPlayerMessage] {
playerPath {
origin {
displayName: "Vardagsrum"
identifier: 1280262988
}
client {
processIdentifier: 175
bundleIdentifier: "com.apple.TVAirPlay"
}
player {
identifier: "MediaRemote-DefaultPlayer"
displayName: "Default Player"
}
}
}What's new to me/pyatv is that MRP seems to care more about the players now. Previous behavior were more in the line of:
- SetState
- UpdateClient
- SetNowPlayingClient
Nothing about players. Normally only SetNowPlayingClient would be sent with a player path (even if SetNowPlayingPlayer also existed as a message). When media stopped playing, it would be sent again but without any player path. Doing in the way it's done above implies that the client (app(?)) is still running and outputting to the default player, but since there's no SetStateMessage for that path there's actual no output/nothing playing. Nothing really strange with that and possibly even a good addition, in case it works similarly with apps. Will have to explore that. One small issue here though is how to be backwards compatible in a decent way.
Just hit me that this is probably because of support for Picture-In-Picture support in tvOS 14. In that case there would be two players active at the same time, possibly from two different apps. I have never tried it myself so I don't know how it works. Some logs would be great for this...
AirPlay is also a bit special as that is the only app I have seen that uses another player than the default player (MediaRemote-DefaultPlayer) even in the past.
Will continue my reasoning here as I get time to look into things. I think I need to define a model for how everything in a player path fits together and implement that in pyatv.
Edit: Logs from above obviously came from a streaming session with a hiccup since nothing appeared to be playing. I believe it was buffering or something. Anyway, I tried again and got the result I expected.
lucasec
Describe the bug It seems like tvOS 14 is handling players, I.e. what determines what is currently playing a bit differently. I have not had the chance to investigate this further yet, but I have an example dump.
To Reproduce I'm playing an example video via AirPlay in one terminal:
I then listen to push updates in another terminal and just stop the AirPlay stream (Ctrl+C):
Characters are encoded wrongly when copying from Termius.
Expected behavior State should be correctly updated to not playing.
System Setup (please complete the following information):
Additional context