postlund / search-card

Quickly search for entities from a Lovelace card.
MIT License
104 stars 13 forks source link

No icon as of 0.110 #21

Closed m1ke-hub closed 4 years ago

m1ke-hub commented 4 years ago

Nothing dramatic - just wanted to let you know the icons don't show as of HA 0.110. Probably related to this https://www.home-assistant.io/blog/2020/05/20/release-110/#icons

postlund commented 4 years ago

Yeah, seems to be the case. Will have to look into that in due time.

m1ke-hub commented 4 years ago

No hurry - doesn't bother me at all

samrenfrew commented 4 years ago

@migo-dev @postlund I managed to fix this locally by replacing 'iron-icon' with 'ha-icon' and changing the 'paper-icon-button' to a standard 'paper-button' and putting the ha-icon inside the element

KTibow commented 4 years ago

@migo-dev mind closing this (I forgot to mention before it was merged, so not auto-closed)?

postlund commented 4 years ago

I think "Fixes #..." must be part of the commit message or PR body for that to work. So that's probably why it didn't work.

m1ke-hub commented 4 years ago

Hey guys, thank you very much. Great improvement! Also thanks for the custom placeholder text 😄 I found a way to get the old close icon back:

[Lines 61-65]

        <ha-icon-button slot="suffix"
                          @click="${this._clearInput}"
                          icon="mdi:close"
                          alt="Clear"
                          title="Clear"></ha-icon-button>

BTW: which part is "responsible" for the small extra x?

KTibow commented 4 years ago

which part is "responsible" for the small extra x?

That's the built-in browser behavior.

KTibow commented 4 years ago

https://stackoverflow.com/questions/14007655/remove-ie10s-clear-field-x-button-on-certain-inputs https://geektnt.com/how-to-remove-x-from-search-input-field-on-chrome-and-ie.html

m1ke-hub commented 4 years ago

Thanks, I see.. is there a way to hide it?

KTibow commented 4 years ago

@migo-dev ??? btw made a new issue for that