Closed KiraElric007 closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a612fbe
) 89.96% compared to head (396eed3
) 89.96%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey, guys, the pr looks good. May you five me permissions to merge prs... Looks like this feature of postman is getting old > 3 months and the non merge of this pr makes this project lag beind when it shoudn't, at least when the reason are the postman vendor libs.
but the test skip is not related with the PR itself, but rather the node version. have we a pr to fix the incompatibility with this test and node v20.10 ?
@vedkribhu The skipped test case, fails for timeout >= 7 ms
for node versions < 20.10.0. This node PR adds a performance improvement in node v20.10.0 resulting in the test failing for timeout >= 4 ms
. There seems to be a race condition that needs to be fixed in postman-runtime/postman-sandbox library.
The test case has been testing an edge case which passes, leaving out all the other cases when it actually fails. Since this is happening in develop as well, we can look into this in a separate PR. Let us not block this PR.
I am attaching below screenshots of test case execution in different node versions with different timeout (All tests are run on develop branch [head commit]).
Test passing in node v16.10.0 with 5ms timeout:
Test failing in node v16.10.0 with 10ms timeout:
Test passing in node v20.10.0 with 3ms timeout:
Test failing in node v20.10.0 with 5ms timeout:
The above screenshot proves that the issue is existing in develop and not introduced because of this PR. We can deep dive into the root cause of this issue and fix it in a separate PR.
cc: @aman-postman
Sourced from postman-runtime's changelog.
Sourced from postman-collection's changelog.