search

postmanlabs / newman

Newman is a command-line collection runner for Postman
https://www.postman.com
Apache License 2.0
6.83k stars 1.16k forks source link

Converted the deprecated `apikey` parameter in Postman API urls to `x-api-key` header #3258

Closed akira28 closed 1 month ago

akira28 commented 1 month ago

The apikey query parameter is a deprecated way to authenticate requests on Postman API. This pull requests converts the query parameter in the url passed by the user, to the x-api-key header, before executing the request to Postman API

harshadixit23 commented 1 month ago

@akira28 I've reviewed and tested on local, able to run collections using environments. Could you please add description in PR and ticket? 😅 Also, something seems to be failing in CI, could you please check?

akira28 commented 1 month ago

@harshadixit23 seems to be an unrelated rate limit issue on Codecov: Rate limit reached. Please upload with the Codecov repository upload token to resolve issue

akira28 commented 1 month ago

@harshadixit23 I tried rerunning it without success

harshadixit23 commented 1 month ago

@akira28 we might also want to squash commits to follow guidelines in https://github.com/postmanlabs/newman/blob/develop/.github/CONTRIBUTING.md#commit-guidelines I'll check with folks from API client about the CI failure

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.89%. Comparing base (4b4823c) to head (2329fa1).

Files Patch % Lines
lib/util.js 92.85% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3258 +/- ## =========================================== - Coverage 81.92% 81.89% -0.03% =========================================== Files 21 21 Lines 1145 1149 +4 Branches 348 351 +3 =========================================== + Hits 938 941 +3 Misses 114 114 - Partials 93 94 +1 ``` | [Flag](https://app.codecov.io/gh/postmanlabs/newman/pull/3258/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=postmanlabs) | Coverage Δ | | |---|---|---| | [cli](https://app.codecov.io/gh/postmanlabs/newman/pull/3258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=postmanlabs) | `71.19% <85.71%> (-0.08%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/postmanlabs/newman/pull/3258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=postmanlabs) | `35.42% <50.00%> (+0.05%)` | :arrow_up: | | [library](https://app.codecov.io/gh/postmanlabs/newman/pull/3258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=postmanlabs) | `51.78% <92.85%> (+0.08%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/postmanlabs/newman/pull/3258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=postmanlabs) | `66.05% <50.00%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=postmanlabs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akira28 commented 1 month ago

@harshadixit23 rebased and squashed