search

postmanlabs / postman-app-support

Postman is an API platform for building and using APIs. Postman simplifies each step of the API lifecycle and streamlines collaboration so you can create better APIs—faster.
https://www.postman.com
5.84k stars 839 forks source link

Postman V10.1.2 has GLIBCXX_3.4.26 build pieces (and should not?) #11431

Closed pjwelsh closed 1 year ago

pjwelsh commented 1 year ago

Is there an existing issue for this?

Describe the Issue

During a file audit, Postman seems to have created some file(s) with a much higher glibc version requirement that all of the other packages (an the required glibc version is not available): ./app/resources/app/node_modules/nsfw/build/Release/obj.target/nsfw.node ./app/resources/app/node_modules/nsfw/build/Release/nsfw.node

Note these also appear to be duplicate files. Should these "build" pieces be here? Why is it requiring GLIBCXX_3.4.26?

Steps To Reproduce

  1. download latest file from https://dl.pstmn.io/download/latest/linux64
  2. extract
  3. ldd opt/Postman/app/resources/app/node_modules/nsfw/build/Release/nsfw.node opt/Postman/app/resources/app/node_modules/nsfw/build/Release/obj.target/nsfw.node
  4. they are 1) duplicate and
  5. 2) "objdump -T opt/Postman/app/resources/app/node_modules/nsfw/build/Release/nsfw.node|grep GLIBCXX_3" shows a dependency on GLIBCXX_3.4

Screenshots or Videos

Screenshot from 2022-11-08 09-50-48

Operating System

Linux

Postman Version

10.1.2

Postman Platform

Postman App

Additional Context?

No response

RaisinTen commented 1 year ago

10.1.2

Is this the first version where this issue was introduced or do you know if other versions are affected too? I'd like to know the first version that has this issue.

pjwelsh commented 1 year ago

Sorry, the last version we had was 9.15.2 (due to a technical issue). That version did not have this issue.

On Wed, Nov 9, 2022 at 12:42 AM Darshan Sen @.***> wrote:

10.1.2

Is this the first version where this issue was introduced or do you know if other versions are affected too? I'd like to know the first version that has this issue.

— Reply to this email directly, view it on GitHub https://github.com/postmanlabs/postman-app-support/issues/11431#issuecomment-1308283797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2ANMENP3OFGNGNVD5ASX3WHNBVRANCNFSM6AAAAAAR2PEF5U . You are receiving this because you authored the thread.Message ID: @.***>

Disclaimer

The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful.

This email has been scanned for viruses and malware, and may have been automatically archived. Cassens

pjwelsh commented 1 year ago

The version we had last was actually 9.16.0 according to the Postman/app/resources/app/package.json file.

RaisinTen commented 1 year ago

FWIW, we had recently added the nsfw dependency for the local git integration in Postman v10 but that's disabled now, so this addon is not used by the postman-app. Therefore, the app should not run into GLIBC versioning issues.

Are you running into any GLIBC versioning issues while running the app though?

pjwelsh commented 1 year ago

Those nsfw folders were removed in order to pass the install audit on our side. I will check with the next version released.

pjwelsh commented 1 year ago

Current version 10.5.2 does not show this issue. closing.