search

postmanlabs / postman-app-support

Postman is an API platform for building and using APIs. Postman simplifies each step of the API lifecycle and streamlines collaboration so you can create better APIs—faster.
https://www.postman.com
5.83k stars 838 forks source link

Allow customising syntax highlighting for code editors #8575

Open openBackhaul opened 4 years ago

openBackhaul commented 4 years ago

Light theme shows wrong syntax highlighting while scripting tests.

Light theme should show syntax highlighting of ace-eclipse, but actually shows ace-monokai.

Postman for Linux Version 7.25.1 linux 4.15.0-101-generic / x64 on Ubuntu 18.04, but same version for Windows has same bug on Windows 8.1.

kamalaknn commented 4 years ago

Hey @openBackhaul

Could you share screenshots of the issue you are seeing?

It would help if you could share steps to reproduce the issue to help us investigate this issue.

openBackhaul commented 4 years ago

Screenshot: image e.g. Strings should be blue and so on.

Steps to reproduce: Open any existing Pre-request Script or Tests script in the Postman application script editor.

kamalaknn commented 4 years ago

hey @openBackhaul

We have replaced the underlying editor from Ace to Monaco in the recent version. We have matched the Monaco themes to give similar look and feel on Postman's light and dark themes.

We are tracking some improvements to syntax highlighting as part of this change here #8463.

If you'd like the ability to customize the syntax highlighting, I'm marking this as a feature request to provide customizability to themes on text editors.

openBackhaul commented 4 years ago

There must have gone something wrong during matching the Monaco themes, because both the light and the dark are now using the Monokai coloring scheme, while the light theme used the Eclipse coloring scheme before.

I would be glad, if the colors would be like before. Customization would also be ok, if entire schemes could be chosen from a list of pre-defined.