postmanlabs / postman-app-support

Postman is an API platform for building and using APIs. Postman simplifies each step of the API lifecycle and streamlines collaboration so you can create better APIs—faster.
https://www.postman.com
5.84k stars 839 forks source link

When part of commented out Json Raw body is uncommented it fully gets uppercased #9114

Open emilianopenedo opened 4 years ago

emilianopenedo commented 4 years ago

Describe the bug When part of commented out Json Raw body is uncommented it fully gets uppercased

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Json Raw Request Body'
  2. Click on 'Ctrl+k + Ctrl+c' to comment Json block
  3. Click on 'Ctrl+k + Ctrl+u' to uncomment Json block (selected text, more than single cursor position)
  4. See error, the uncommented block converted to uppercase

Expected behavior Keep original Json case unchanged

App information (please complete the following information):

DannyDainton commented 4 years ago

Hey @emilianopenedo

Are you able to provide a short recording of this happening in the app, please?

ritwijsinha commented 4 years ago

Hey @emilianopenedo,

Thank you for reporting this. We were able to reproduce the bug on Windows. As a workaround, can you please try using Ctrl + / to comment/uncomment blocks?

Cheers 🎉

emilianopenedo commented 4 years ago

Hey @emilianopenedo,

Thank you for reporting this. We were able to reproduce the bug on Windows. As a workaround, can you please try using Ctrl + / to comment/uncomment blocks?

Cheers 🎉

Thank you @ritwijsinha I've tried with Ctrl + / with no success. I't seems that the shortcut mappings are the same as VSCode, then I've found that using Ctrl + ç works with my keyboard distribution (sp intl) and keeps the case as expected.

ghost commented 3 years ago

This is becoming quite annoying that it still hasn't been fixed. Ctrl + / doesn't work. It just opens settings on my end.

MarkusSeb commented 2 years ago

Postman developer are not able to fix this issue. Workaround: use shift-alt-mouse click to select slashes and remove

qfyra commented 2 years ago

Found this issue today. I find it very peculiar that this is still an issue.

giridharvc7 commented 1 year ago

I can see Ctrl + / working, can someone verify if this is still a problem?

hammad1-byte commented 1 year ago

I can see ctrl + / working, I guess for postman we have to use 'ctrl + /for comment/uncomment both. As we are developers and most of other code editors use 'ctrl + k , ctrl + c to comment and ctrl + k, ctrl + u to uncomment the code. :)

TiagoSantosDeveloper commented 1 year ago

Hello! =)

Everything indicates that it is a conflict of shortcuts.

The software needs to differentiate that Ctrl+K+U is for comment only and Ctrl+U is for uppercase text. Not both at the same time.

felipedrumond commented 1 year ago

This is still a problem. Some APIs won't recognize the values if they are not normalizing the values internally.

aureole82 commented 1 year ago

@postman-staff What's the problem?

Either kick Ctrl+K,Ctrl+U (bad for Visual Studio Code users) or kick uppercasing by Ctrl+U! You cannot have both!

Viltersten commented 1 year ago

The amount of times an average developer uncomments is by any measure vastly larger than when they desire to upper case. Even SQL folks started nowadays to make the code NOT SHOUT at us...

leandrosa commented 1 year ago

I think it depends of the layout of the keyboard. For me for example, it worked with Ctrl + ~ to comment and uncomment.

SyedAzeemJaved commented 6 months ago

The issue also occurs on Linux (Pop!_OS 22.04 LTS)

farhanalie commented 6 months ago

This is still a problem, after going through the comments I tried Ctrl + / and Ctrl + ~ which didn't work for me on Swedish keyboard. What worked for me is Ctrl + '.

MarkusSeb commented 6 months ago

thank you very much. It works

Sussumu commented 2 hours ago

Indeed Ctrl + / works but I still would like to see a fix here. If you have multiple commented and non-commented blocks you have to select only the comments or you're going to have multiple double comments using the slash shotcut.

I also agree that the uppercase shortcut has less priority here. Maybe a right click edit option is enough.