Closed aarifkhan7 closed 6 months ago
Hey @aarifkhan7,
It is entirely optional to close PHP with ?>
, it is even considered a good practice to not close PHP tags.
You can read more about it here.
I am closing the PR, you can open it for further discussions.
Fixes #640 Issue: The code generators for php, generates snippet without ?> end tag.
Code Snippet: `<?php
$curl = curl_init();
curl_setopt_array($curl, array( CURLOPT_URL => 'https://postman-echo.com/get?test=123', CURLOPT_RETURNTRANSFER => true, CURLOPT_ENCODING => '', CURLOPT_MAXREDIRS => 10, CURLOPT_TIMEOUT => 0, CURLOPT_FOLLOWLOCATION => true, CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1, CURLOPT_CUSTOMREQUEST => 'GET', ));
$response = curl_exec($curl);
curl_close($curl); echo $response; `
The Code snippet after the fix looks like: `<?php
$curl = curl_init();
curl_setopt_array($curl, array( CURLOPT_URL => 'https://postman-echo.com/get?test=123', CURLOPT_RETURNTRANSFER => true, CURLOPT_ENCODING => '', CURLOPT_MAXREDIRS => 10, CURLOPT_TIMEOUT => 0, CURLOPT_FOLLOWLOCATION => true, CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1, CURLOPT_CUSTOMREQUEST => 'GET', ));
$response = curl_exec($curl);
curl_close($curl); echo $response;
?>`