postmates / cernan

telemetry aggregation and shipping, last up the ladder

Other

315 stars 11 forks source link

Update FlushTimer and flush_interval related code to support sub-second flushing of sinks. #449

Closed dparton closed 6 years ago

dparton commented 6 years ago

This introduces a flushes_per_second() public function, accessible through the source module. This PR increases the flush frequency from 1hz to 100hz. Old configuration files remain backwards compatible. The new code will continue to accept flush_interval values that are integers, but will also now accept floating point values in order to specify sub-second flush intervals. At 100hz, the lowest delay is 10ms.

codecov[bot] commented 6 years ago

Codecov Report

Merging #449 into master will increase coverage by 0.18%. The diff coverage is 97.5%.

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   91.94%   92.13%   +0.18%     
==========================================
  Files          29       30       +1     
  Lines        4037     4041       +4     
==========================================
+ Hits         3712     3723      +11     
+ Misses        325      318       -7

blt commented 6 years ago

Looking through now.

On Tue, Aug 14, 2018, at 7:39 AM, John Koenig wrote:

@pulltab approved this pull request.

LGTM.

@blt[1] Any objections?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub[2], or mute the thread[3]. Links: