search

postmatic / postmatic-social

Lightweight social commenting for WordPress
GNU General Public License v2.0
5 stars 3 forks source link

Ask for email address if/when using twitter #27

Closed Vernal closed 8 years ago

Vernal commented 8 years ago

If the user is using Postmatic and signs in with Twitter we should ask them for an email address for followup comments. Could be difficult.

DannyBrownCA commented 8 years ago

Not sure if that would make sense. Adds hoops to jump through, and commenter probably using Twitter to comment as they don't want email?

Vernal commented 8 years ago

It'd only ask them if they check the box to subscribe by email.....

On Mon, Oct 26, 2015 at 3:30 PM, DannyBrownCA notifications@github.com wrote:

Not sure if that would make sense. Adds hoops to jump through, and commenter probably using Twitter to comment as they don't want email?

— Reply to this email directly or view it on GitHub https://github.com/postmatic/social/issues/27#issuecomment-151258445.

Jason G. Lemieux | Creative Director Vernal Creative and Strategy http://www.vernalcreative.com | New Number - 802.821.4059

DannyBrownCA commented 8 years ago

So they'd still see box if commenting via social? Or is that just Twitter?

Vernal commented 8 years ago

They would see the subscribe via email box no matter what network they use. We are able to scrape their email from all networks except for Twitter.

In the case of Twitter, if they checked the box, we'd have to throw up a prompt asking them what address they want to use... :(

On Mon, Oct 26, 2015 at 3:33 PM, DannyBrownCA notifications@github.com wrote:

So they'd still see box if commenting via social? Or is that just Twitter?

— Reply to this email directly or view it on GitHub https://github.com/postmatic/social/issues/27#issuecomment-151259425.

Jason G. Lemieux | Creative Director Vernal Creative and Strategy http://www.vernalcreative.com | New Number - 802.821.4059

DannyBrownCA commented 8 years ago

OK, that makes sense. Though wondering if the "scrape email addresses" would need a new disclosure policy, as well as upfront messaging and permissions to do so?

Vernal commented 8 years ago

It asks the user for the email address when they first link their social account. It's clear at that step...

On Mon, Oct 26, 2015 at 3:38 PM, DannyBrownCA notifications@github.com wrote:

OK, that makes sense. Though wondering if the "scrape email addresses" would need a new disclosure policy, as well as upfront messaging and permissions to do so?

— Reply to this email directly or view it on GitHub https://github.com/postmatic/social/issues/27#issuecomment-151260904.

Jason G. Lemieux | Creative Director Vernal Creative and Strategy http://www.vernalcreative.com | New Number - 802.821.4059

ronalfy commented 8 years ago

I tried my best to get an e-mail address working, but the Twitter one always takes precedence. If I have more time, I'll give this another go.

ronalfy commented 8 years ago

Should be fixed / addressed here. https://github.com/postmatic/social/pull/36

ronalfy commented 8 years ago

Please close if your tests come back positive.