search

postmodern / ffi-hunspell

Ruby FFI bindings for Hunspell.
MIT License
48 stars 24 forks source link

Add Hunspell 1.4.1 #16

Closed ahanmal closed 8 years ago

ahanmal commented 8 years ago

Homebrew now installs hunspell 1.4.1. This PR adds support for the latest version.

kaikuchn commented 8 years ago

This is superfluous, 1.4 is sym-linked to 1.4.1 per default

❯ ls -al /usr/local/lib/libhunspell-1.4.dylib
l********  1 *****  *****  50 Sep 22 09:46 /usr/local/lib/libhunspell-1.4.dylib -> ../Cellar/hunspell/1.4.1/lib/libhunspell-1.4.dylib

Also see PR #14

kaikuchn commented 8 years ago

However, it would be nice if @postmodern could release the gem with support for version 1.4 :)

binarydev commented 8 years ago

@ahanmal this is an issue if you use the currently published gem from rubygems.org, but if you set the source to the current version on Github, it has already been resolved.

ahanmal commented 8 years ago

@binarydev In the end I was using my own git fork which was based on the current master, so that might've also led to fixing the issue.

@kaikuchn I see what you're saying now. Odd that brew didn't install it as such on my old system (I recently did a clean install of macOS) - might've been the Sierra beta? Oh well - I'm going to close this as everything is working fine now.