Open judofyr opened 4 years ago
We could remove the clean step entirely and just hope that ./configure
and the Makefile
are smart enough to regenerate any pre-existing artifacts?
Ah, so the purpose of the clean step is to handle the case where you've tried to compile it once and you're trying again? Then it will use the same directory?
if so, maybe it's better to remove the cleaning step and instead support --clean
which will re-download. Seems like a more sensible "clean" operation than make clean
.
@judofyr could you do a quick test in your environment to whether make clean
is the culprit? That forum post mentioned make distclean
which is different. If make clean
is being problematic, then it will need to be removed.
I just got this error:
I found some old forum post which suggests that the issue is that we're cleaning before compiling, and the cleanup deletes files which are needed for the compilation:
https://github.com/postmodern/ruby-install/blob/402cbdeaffb99d105ecd9b93c75828b32f0f382f/bin/ruby-install#L47-L51
Is it possible for the cleanup step to be moved further down? Maybe even after the install step?