search

postmodern / ruby-install

Installs Ruby, JRuby, TruffleRuby, or mruby
MIT License
1.9k stars 252 forks source link

Fail truffleruby installation if install_dir is /usr/local #401

Closed missingcharacter closed 3 years ago

missingcharacter commented 3 years ago

Trying to close https://github.com/postmodern/ruby-install/issues/398

postmodern commented 3 years ago

Thoughts on moving the fail into the install_ruby function, at the top?

missingcharacter commented 3 years ago

@postmodern like this (see new commit) or turn it into an if?

postmodern commented 3 years ago

@missingcharacter yeah if would be better since we're only doing one comparison.

Also, since we're in the install_ruby function, we could also use error and return 1 to abort back to bin/ruby-install where a generic error message would also be printed. You're call on whether to print one error message and immediately exit, or print two error messages.

missingcharacter commented 3 years ago

@postmodern how about now?

postmodern commented 3 years ago

Squash merged, even though GitHub Actions keeps failing shunit2 test suites only on macOS; still need to investigate that.