search

postmodern / ruby-install

Installs Ruby, JRuby, TruffleRuby, or mruby
MIT License
1.9k stars 252 forks source link

Force homebrew to use OpenSSL 1.1 #410

Closed emptyflask closed 2 years ago

emptyflask commented 2 years ago

OpenSSL 3.0 is released, and Homebrew uses it by default now, but Ruby doesn't support it yet. See the issue at https://github.com/postmodern/ruby-install/issues/409

emptyflask commented 2 years ago

Tested building the latest ruby, truffleruby, and truffleruby-graalvm. rbx seems broken for an unrelated reason, but I'd be surprised if it's expecting a newer openssl.

postmodern commented 2 years ago

Looks good. Unpinning openssl when rubies start supporting OpenSSL 3.0 may be tricky. OpenSSL 1.1 appears to still be maintained for now, so we don't have to worry about missing any security updates if we continue to target 1.1. Eventually we will want to unpin and switch back to 3.0.

postmodern commented 2 years ago

ruby-install 0.8.3 has been released. Now we wait for homebrew to pick it up.

aduh95 commented 2 years ago

https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/ lists that they have updated OpenSSL to 3.0.0, won't that conflict with this change?

dgholz commented 1 year ago

https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/ lists that they have updated OpenSSL to 3.0.0, won't that conflict with this change?

That's the openssl gem's version, which tends to follow the max OpenSSL version it supports. It still works fine with OpenSSL 1.1