search

postmodern / ruby-install

Installs Ruby, JRuby, TruffleRuby, or mruby
MIT License
1.89k stars 250 forks source link

Fix macos handling for truffleruby artifacts #454

Closed rwstauner closed 1 year ago

rwstauner commented 1 year ago

We change darwin to macos at the top of this file.

I confirmed that on my mac i can install

postmodern commented 1 year ago

@eregon any other testing or fixes, or should I start preparing a 0.9.1 release?

nirvdrum commented 1 year ago

@postmodern I think we're all set now. It was an unfortunate copy & paste issue. @rwstauner has verified the macOS builds install correctly and @eregon had confirmed the Linux ones do as well. Whenever GitHub adds support for macOS ARM machines we may do well to add automated tests that check the tarball downloads work.

eregon commented 1 year ago

Yes, all good, a release would be great :)

postmodern commented 1 year ago

Will try to do that tomorrow, after the dentist appointment.