A versatile Ruby web spidering library that can spider a site, multiple domains, certain links or infinitely. Spidr is designed to be fast and easy to use.
The HTTP status code for timedout is 408 not 308. This PR:
fixes the status code int used in Page#timedout?
changes the name of the method to is_timedout? for consistency with other methods
aliases the changed method to timedout? for consistency with other methods
moves the method within the file so it's in the correct place with respect to the sequential ordering by status code (probs not necessary but I'm not a total monster)
updates the rspec
I couldn't find any guidance on contributing, so if I've missed anything anywhere, LMK! 🎈
postmodern
commented
2 years ago
The HTTP status code for timedout is
408not308. This PR:Page#timedout?is_timedout?for consistency with other methodstimedout?for consistency with other methodsI couldn't find any guidance on contributing, so if I've missed anything anywhere, LMK! 🎈