search

postnl / postnl-magento1-End-of-life

This is the official Magento 1 extension of PostNL.
12 stars 9 forks source link

Keep sorting from grid #40

Closed seansan closed 4 years ago

seansan commented 5 years ago

Proposed file changes to solve #39

Needs testing but seems to work locally

tig-dennisvanderhammen commented 5 years ago

Hi Sean,

Thank you for your proposal and pull request. It is up to PostNL if we want this included in the extension. I'll get in touch with PostNL to see if they would like this PR to be accepted.

I'll keep this PR and the other issue up to date as soon as I get a response from PostNL.

seansan commented 5 years ago

Welcome

there is an error in code @ public function createShipments(array $orderIds, $loadExisting = false, $registerExisting = true)

foreach was using collection instead of ids

            if ($shipmentCollection->getSize() > 0) {
                // $shipmentIds = array_merge($orderShipmentIds,

$shipmentIds); foreach ($orderShipmentIds as $_allreadyshipped) {

On Thu, Dec 27, 2018 at 11:14 AM Dennis van der Hammen < notifications@github.com> wrote:

Hi Sean,

Thank you for your proposal and pull request. It is up to PostNL if we want this included in the extension. I'll get in touch with PostNL to see if they would like this PR to be accepted.

I'll keep this PR and the other issue up to date as soon as I get a response from PostNL.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tig-nl/postnl-magento1/pull/40#issuecomment-450122005, or mute the thread https://github.com/notifications/unsubscribe-auth/AAn0a0K55pVgbbXyDIkSISDV3YUahIZiks5u9J2VgaJpZM4ZghF9 .

tig-dennisvanderhammen commented 5 years ago

Hi Sean,

Thanks for the update. I'll keep that in mind if we do end up placing this in the Magento extension.

seansan commented 5 years ago

This is a very important update for high volume users. Without it is hard to optimize shipping processes and time is spent searching for the correct packingslip for each order

tig-dennisvanderhammen commented 5 years ago

It's currently in PostNL their hands to decide if they want to include this. If you really do feel like this issue needs to have more priority, I recommend getting in touch with your accountmanager.

tig-jaspersmits commented 4 years ago

Magento 1 is getting closer to EOL and therefore we have switched our focus to the Magento 2 extension. I will hereby close this ticket.