Upgrade to latets version @ 16/8/19 warning in logs

[seansan]

2019-08-16T12:57:46+00:00 ERR (3): Notice: Undefined offset: 1 in app/code/community/TIG/PostNL/Model/Adminhtml/Observer/OrderGrid.php on line 775

[tig-dennisvanderhammen]

Hi Sean,

Could you please include the issue template, and also give some context about when and where you get this notice?

To me it seems like the same notice that you've created an issue for before, which we concluded about that it was related to products not existing anymore, but because we're missing a lot of context here, I can't help you any further.

[seansan]

No more context it is appearing in our logs multiple times since upgrade

On Fri, 16 Aug 2019 at 16:32, Dennis van der Hammen < notifications@github.com> wrote:

Hi Sean,

Could you please include the issue template, and also give some context about when and where you get this notice?

To me it seems like the same notice that you've created an issue for before, which we concluded about that it was related to products not existing anymore, but because we're missing a lot of context here, I can't help you any further.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tig-nl/postnl-magento1/issues/59?email_source=notifications&email_token=AAE7I26EBBNGGCRSMKKKE7TQE226VA5CNFSM4IMI666KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4OYZIY#issuecomment-522030243, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE7I232FCJXXYF6BXVXXZLQE226VANCNFSM4IMI666A .

[tig-dennisvanderhammen]

Are you able to reproduce this on a clean Magento environment with PostNL installed?

[seansan]

The warning comes from here

key is expected to exist when it does not exist

changed to

    foreach ($shippingPhases as $key => $phase) {
        if array_key_exists($key, $values) {
            $html .= $this->_decorateShippingPhase($phase, $values[$key]);
        }
    }

but maybe there is a reason for this warning and it needs to be fized elsewhere, my solution only fixes the warning

[tig-dennisvanderhammen]

Hi Sean,

Perhaps you missed my last comment. If you aren't able to reproduce your issue on a clean environment, please get in touch with the PostNL servicedesk by emailing citservicedesk@postnl.nl.

We have to justify how we spend our time, so we can only dedicate ourself on issues that happen on a core environment.