search

postnl / postnl-magento1-End-of-life

This is the official Magento 1 extension of PostNL.
12 stars 9 forks source link

[BUG] Occasional Error in API #64

Closed seansan closed 4 years ago

seansan commented 4 years ago

To Reproduce Steps to reproduce the behavior:

  1. Ship order using multi action (happens occiasional, see error report)

Expected result Success or at least a warning that tells us WHAT is wrong, or WHICH order and why

Actual result Logging 2020-05-15T11:55:03+00:00 ERR (3): Notice: Undefined offset: 0 in /public_html/app/code/community/TIG/PostNL/Model/AddressValidation/Cendris/Abstract.php on line 122 2020-05-15T11:55:03+00:00 ERR (3): Notice: Trying to get property 'city' of non-object in /public_html/app/code/community/TIG/PostNL/Model/AddressValidation/Cendris/Abstract.php on line 87 2020-05-15T11:55:03+00:00 ERR (3): Notice: Trying to get property 'streetName' of non-object in /public_html/app/code/community/TIG/PostNL/Model/AddressValidation/Cendris/Abstract.php on line 88

Workaround None

Screenshots

Possible solution Improve error report in browser to tell WHAT is wrong Improve error report in logging for WHICH order this is occuring Quick win, in the end we want to fix the order and continue

Please complete the following information

tig-jaspersmits commented 4 years ago

Hello @seansan ,

Thanks for submitting this. Could you explain what you mean with "Ship order using multi action". This isn't entirely clear to me. If you could clarify this for me, I'll test this on our test environment.

Thanks in advance.

Kind regards, Jasper

seansan commented 4 years ago

image

tig-jaspersmits commented 4 years ago

Hi @seansan ,

Just tried to see if I would get any errors, but this works without any problems. Is this purely a feature request to add extra logging to the M1 extension? We aren't expanding the M1 extension any further since M1 is reaching EOL soon.

Kind regards, Jasper TIG

seansan commented 4 years ago

Soon is not now. And support for current functionality is guaranteed for 2 years by postnl. And extra logging is not a new feature .. it solves problems. Current problems. We see this error every once in a while ... why?

tig-jaspersmits commented 4 years ago

I don't know, you will have to submit this through PostNL. Because I'm unable to reproduce what you are getting in the logs.

seansan commented 4 years ago

And I cannot send you the info, because the logging is not specific enough to tell me which

On Mon, May 18, 2020 at 11:16 AM Jasper Smits notifications@github.com wrote:

I don't know, you will have to submit this through PostNL. Because I'm unable to reproduce what you are getting in the logs.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tig-nl/postnl-magento1/issues/64#issuecomment-630054936, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE7I25XLSAGFEKFOTQTDPLRSD4GDANCNFSM4NBRN2FA .

tig-dennisvanderhammen commented 4 years ago

Hi,

As we are unable to reproduce the mentioned errors (or notices) on a core environment with the latest version (v1.16.3) installed, I'll be closing the issue.

If you want further support on the specific question on hand, or if you want changes in the way error handling currently works, please get in touch with PostNL by sending an e-mail to digitaleklantsupport@postnl.nl.