postnl / postnl-magento2

This is the official Magento 2 extension for the logistics company PostNL. Add shipping options and parcelshops to your checkout. Create labels with track and trace functionality from the backend.
58 stars 61 forks source link

[BUG] sender address on label is always The Netherlands #236

Closed akosglue closed 2 years ago

akosglue commented 3 years ago

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Sales / Order'
  2. Click on 'Create Shipment'
  3. Click on 'PostNL - Print Label' on that shipment

Expected result I expect to have the sender country in the sender address. However, it can't be changed via the magento admin panel.

Actual result THE NETHERLANDS remains in the sender address.

Workaround I just made a patch to hotfix my issue. `diff --git a/vendor/tig/postnl-magento2/Webservices/Api/Customer.php b/vendor/tig/postnl-magento2/Webservices/Api/Customer.php index c7007a52..946045dd 100644 --- a/vendor/tig/postnl-magento2/Webservices/Api/Customer.php +++ b/vendor/tig/postnl-magento2/Webservices/Api/Customer.php @@ -112,7 +112,7 @@ class Customer 'HouseNrExt' => $this->addressConfiguration->getHousenumberAddition($this->storeId), 'Zipcode' => strtoupper(str_replace(' ', '', $this->addressConfiguration->getPostcode($this->storeId))), 'City' => $this->addressConfiguration->getCity($this->storeId),

`

Screenshots Not applicable, the address is shown on the label.

Please complete the following information

tig-jeffreybranderhorst commented 3 years ago

Hi @akosglue ,

At this moment the PostNL extension only uses product codes for the Netherlands, that is also the reason why you cannot change your sender country. This is something that is on our backlog and in the future this will be added to the extension, currently we don't have an ETA for this yet.

Have a nice day, Jeffrey

tig-vincentthart commented 2 years ago

Hi @akosglue ,

Within the latest versions of the plugin this has been resolved.

Have a nice day! Vincent