postnl / postnl-magento2

This is the official Magento 2 extension for the logistics company PostNL. Add shipping options and parcelshops to your checkout. Create labels with track and trace functionality from the backend.
58 stars 60 forks source link

[BUG] Issue with latest update and configurable products with qty of child item #282

Closed JoostWan closed 2 years ago

JoostWan commented 2 years ago

With the latest version (1.10.0) there is a issue with configurable products and the qty of the child product.

Steps.

  1. Place a order with a configurable product with a QTY of 2
  2. Place the order and select a PostNL Shipping method

Now the item of the child product has a qty of 4 in the database instead of 2. You can check it in table sales_order_item

When you have a QTY of 4 the child gets a QTY of 16.

In our case we used the qty_ordered for the fulfilment company, so the customer get two free products.

Screenshot 2021-11-25 at 13 47 25

When we disable this line the problem is "solved"

https://github.com/tig-nl/postnl-magento2/blob/master/Service/Shipping/LetterboxPackage.php#L211

This issue is related I think, https://github.com/tig-nl/postnl-magento2/issues/278

tig-jeffreybranderhorst commented 2 years ago

Hi @JoostWan ,

We are aware of this being an issue right now. We are working hard on a solution for this issue! The plan is to roll out a solution in a few days. Thank you for submitting this.

Have a great day, Jeffrey

tig-jeffreybranderhorst commented 2 years ago

Hi,

we have made a 1.10.1 release with a change in the configurable products. Can you test @JoostWan if this also solves your problem?

Have a great day, Jeffrey

memen45 commented 2 years ago

The update 1.10.1 does not show up with composer. It seems the composer.json file was not updated with the new version number. composer show tig/postnl-magento2 shows 1.10.0 as latest version.

tig-jeffreybranderhorst commented 2 years ago

Hi @memen45,

Thank you for giving us a heads up, we updated the version number!

Have a great day, Jeffrey

memen45 commented 2 years ago

Thanks, I think I was able to install the new version. I cannot verify in admin panel as it still shows 1.10.0, but that is probably this line that was also not updated.

Will test if the update works.

tig-jeffreybranderhorst commented 2 years ago

Hi @memen45,

You are correct that the label in the backed did not update. We understand that this can be confusing, we are going to change this. Thank you for notifying us! If you did update the extension through composer it should have worked!

Have a great day, Jeffrey

tig-jeffreybranderhorst commented 2 years ago

Hi @memen45,

Small update, the next version will have the correct labels in the backend. Thanks again for bringing this to our attention.

Have a great day, Jeffrey