search

postnl / postnl-magento2

This is the official Magento 2 extension for the logistics company PostNL. Add shipping options and parcelshops to your checkout. Create labels with track and trace functionality from the backend.
59 stars 60 forks source link

[BUG] Billing housenumber missing after update to 1.12.2 #317

Closed ZIPITRO closed 2 years ago

ZIPITRO commented 2 years ago

Make sure you are using the latest version: https://tig.nl/postnl-magento-extensies/

[x] I've verified

What is the purpose of your issue?

[x] Bug report (encountered problems with the TIG PostNL Magento extension) [x] This issue does not contain any security sensitive information

If the purpose of your issue is a bug report

You can reproduce with below steps: (only guests experience this)

  1. Add product to basket
  2. Go to checkout
  3. Fill in your email, name, address and phone number
  4. Summary shows the billing house number

checkout-summary-ok

After completing the order it shows the billing house number empty( non expected result )

order-billing-hn-missing

Expected result

order-billing-hn-expected-result

Images are for reference only and shown addresses may mix up, but it shows the result, which is different than the expected result.

Please check and let us know if there is any workaround available.

Have a great day!

tig-jeffreybranderhorst commented 2 years ago

Hi @ZIPITRO ,

We just tested on a clean Magento, and we could not reproduce this issue. We think this happens because you are using a One step checkout? We would recommend to contact PostNL directly to talk about the One step checkout support. You can contact them via digitaleklantsupport@postnl.nl

Have a great day, Jeffrey

ZIPITRO commented 2 years ago

Hi Jeffrey,

Thank you for your feedback, but the previous versions were not an issue, we already stopped using the PostNL address check which introduced other trouble which was luckily fixed by using another address checker.

We have a One Page checkout and had zero issues for a little while till this version, I will talk to my clients and contact PostNL.

ZIPITRO commented 2 years ago

I think I fixed it, will let you know later if its stable.

ZIPITRO commented 2 years ago

Its not fixed, I made a workaround for our existing export and I will till there is an update have to manually change the billing house number to have proper invoices, this causes a lot of work.

Which code is responsible for the billing house number?

ZIPITRO commented 2 years ago

Works only good when the address check of the postnl module is used, does not work anymore when you have a third party module in use for postcode checks. Please improve third party compatibility.

tig-jeffreybranderhorst commented 2 years ago

Hi @ZIPITRO ,

Thank you for all the information, third party compatibility for one step checkouts is not supported yet. You can contact digitaleklantsupport@postnl.nl to tell them you need this. If PostNL then decided it should be added we will make the extensions compatible but at this moment there is no compatibility with one step checkouts, and it is not yet wished for by PostNL, I suggest you contact PostNL for this to let them know you need it.

Have a great day, Jeffrey

ZIPITRO commented 2 years ago

Good morning Jeffrey,

We fixed it,

if it ain't broke, don't fix it