postnl / postnl-magento2

This is the official Magento 2 extension for the logistics company PostNL. Add shipping options and parcelshops to your checkout. Create labels with track and trace functionality from the backend.
58 stars 61 forks source link

[BUG] compile error unexpected 'static' (T_STATIC) #366

Closed GuidoHub closed 11 months ago

GuidoHub commented 1 year ago

When running setup:di:compile after installing the latest version 1.12.9 you will get a compile error when running PHP version lower then 8 because in file Config\Model\Backend\DeliveryDateOff.php on row 88 you use static as return method for the function. This is only available from PHP 8 and higher.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'

Expected result No error when running PHP 7.X

Actual result unexpected 'static' (T_STATIC)

Workaround Chaning file manually

Please complete the following information

JorisPostNL commented 11 months ago

Hi GuidoHub,

This issue was fixed in the V1.12.9.1 release.

Kind regards Team Channel Integrations PostNL