search

postnl / postnl-magento2

This is the official Magento 2 extension for the logistics company PostNL. Add shipping options and parcelshops to your checkout. Create labels with track and trace functionality from the backend.
58 stars 61 forks source link

[FEATURE] Add flag $forceMagento during generate packingslip #374

Closed yaroslav-qlicks closed 7 months ago

yaroslav-qlicks commented 8 months ago

As a admin user I'd like to generate packingslip magento even xtento or fooman modules enabled and compatibility working

I suggest to add extra flag to method signature with default value to keep back compatibility

\TIG\PostNL\Service\Shipment\Packingslip\GetPackingslip::get($shipmentId, $withLabels = true, $confirm = true, $forceMagento = false)

In this case in my own module I can set $forceMagento = true and generate magento pdf even when xtento or fooman present because now there are no option to control this

JorisPostNL commented 7 months ago

Hello @yaroslav-qlicks, thank you for bringing this to our attention. We have developed a fix for this issue and will release this as soon as possible.

Kind regards Joris PostNL Support

JorisPostNL commented 3 months ago

Hi @yaroslav-qlicks, this change has now been deployed

Kind regards Joris PostNL Support