Compatibility with danslo CleanCheckout

[JeroenVanLeusden]

We'd like to use danslo/CleanCheckout. Are there plans to make PostNL compatible? Both modules made changes in view/frontend/web/template/shipping.html although the changes in danslo/CleanCheckout seem to be minor.

[tig-jeffreybranderhorst]

Good morning JeroenVanLeusden,

Until now we don't support any checkout. This is a feature that will come in the future. But I know that that the OneStepCheckout from iDEV is working with the PostNL extension. Their website is: https://www.onestepcheckout.com/

Hopefully in informed you enough.

Beste regards, Jeffrey Branderhorst

[danslo]

I just came across this issue by chance. It shouldn't be too hard to make it compatible yourself. Just override that file in your theme by copying over the file from this module (TIG PostNL), as I assume that's where more changes were done.

Then apply the same changes I made in CC. Here's a diff between core magento and my version:

--- /home/daniel/Code/magento2/app/code/Magento/Checkout/view/frontend/web/template/shipping.html
+++ /home/daniel/Desktop/shipping_cc.html
@@ -32,17 +32,20 @@
         <!-- Inline address form -->
         <render if="isFormInline" args="shippingFormTemplate" />
     </div>
+    <br class="clearfix" />
 </li>

-<!--Shipping method template-->
 <li id="opc-shipping_method"
     class="checkout-shipping-method"
-    data-bind="fadeVisible: visible(), blockLoader: isLoading"
+    data-bind="fadeVisible: visible(), blockLoader: !shouldHideShipping() && isLoading"
     role="presentation">
     <div class="checkout-shipping-method">
+
+        <!-- ko ifnot: shouldHideShipping() -->
         <div class="step-title"
              translate="'Shipping Methods'"
              data-role="title" />
+        <!-- /ko -->

         <each args="getRegion('before-shipping-method-form')" render="" />

@@ -57,7 +60,9 @@
                   submit="setShippingInformation"
                   novalidate="novalidate">

+                <!-- ko ifnot: shouldHideShipping() -->
                 <render args="shippingMethodListTemplate"/>
+                <!-- /ko -->

                 <div id="onepage-checkout-shipping-method-additional-load">
                     <each args="getRegion('shippingAdditional')" render="" />

And unless you really care about hiding shipping methods, you don't even need to apply this patch at all probably.

[JeroenVanLeusden]

@danslo We've already made it compatible ourselves. But, if all it does is hiding shipping methods we might remove it again for better maintainability when upgrading. Thanks for the info!

[tig-jeffreybranderhorst]

Goodmorning JeroenVanLeusden and Danslo,

I'm happy to announce that the TIG PostNL extension is gonna be compatible soon with the checkout, we are working on it right now! Here is a little sneak peak.

So keep your eye out for a tweet for when we are done testing everything! And I will also update this issue. Also, our TIG Postcodeservice will be compatible with the checkout!

Hope I have given you the information you hope for! Got some more question don't hesitate and just call us.

Kind regards, Jeffrey Branderhorst

[danslo]

If I need to do anything in Clean Checkout to make that compatibility cleaner, let me know!

[tig-jeffreybranderhorst]

Hey Danslo,

Today we released a new version of the PostNL extension and this one should be compatible with the checkout!

Kind regards, Jeffrey Branderhorst