Update to RSpec expect syntax

postrank-labs / postrank-uri

URI normalization, c14n, escaping, and extraction

MIT License

301 stars 52 forks source link

Update to RSpec expect syntax #33

Closed odlp closed 7 years ago

odlp commented 7 years ago

The RSpec should syntax is deprecated. We can modernise the test suite by migrating to expect syntax, assisted by the transpec gem.

This PR also resolves Ruby lint warnings about using == in specs.

Finally, it rewords spec names by removing "should". Lets be deterministic 💪. If this stylistic change is unwanted that commit can be removed easily, but it's recognised on BetterSpecs.

igrigorik commented 7 years ago

LGTM. As an aside.. It'd be nice to setup travis builds :-)