Access Token getting deleted from localstorage - Githubissues

posttwo / fjmod-extension

Chrome extension for FunnyJunk moderators

https://funnyjunk.com

0 stars 1 forks source link

Access Token getting deleted from localstorage #14

Closed thunderysteak closed 7 years ago

thunderysteak commented 7 years ago

Access Token getting deleted from localstorage by either accidental user deletion, chrome itself or by other extensions Workaround needed

posttwo commented 7 years ago

chrome.storage.sync is the fix but that means I cant copy paste it like a dummy to firefox when im tired of chrome :(

posttwo commented 7 years ago

also would require window messaging and/or moving everything from injected scripts to content scripts

posttwo commented 7 years ago

wish I could add features straight to funnyjunk

thunderysteak commented 7 years ago

Ask admin if it's possible to add a mod identifier (Hidden element in code) that could replace the token system and automatically detect that the extension user is a mod

posttwo commented 7 years ago

He would need to give an api endpoint for fjmod to verify the username and mod status Was thinking of making a bot that works via PMs @_@

thunderysteak commented 7 years ago

How about creating a bot that will verify an user as a mod and generate new token when requested? Something like old Garrysmod.org verification method before Steam's OAuth was a thing

Bot instructs mod to enable their mod rewards and make their profile public
Bot gives mod a random string to place into their profile description
Bot verifies that the user is a mod by checking if a mod reward icon is found on the profile
Bot also verifies the mod's identity by finding the random string on the page
After verification is finished, bot spits out a randomly generated Authentication Token for user

This eliminates the need to fix this bug

posttwo commented 7 years ago

Replace "bot" by "Felris" and you have the current setup :^ )

posttwo commented 7 years ago

FunnyJunk OAuth would be nice imo

posttwo commented 7 years ago

Can fix if I would change https://github.com/posttwo/fjmod-extension/blob/bb9c262330f8afd1075f002175f2b4f35b603665/src/inject/inject.js#L56 to chrome.storage.sync or whatever.

posttwo commented 7 years ago

Anyway fjmodbot should be enough to take care of this for now