posttwo / fjmod-extension

Chrome extension for FunnyJunk moderators
https://funnyjunk.com
0 stars 1 forks source link

"Mass flag" option flags only comments displayed on page and not all user comments #41

Open thunderysteak opened 7 years ago

thunderysteak commented 7 years ago

Found out by ashedust

posttwo commented 7 years ago

Limitation due to how it currently works the Android API admin added allows pulling all users comments as json, will switch to that asap.

posttwo commented 7 years ago

Android app currently doesn't let you go to page two of comments

    "latest_comments": [
        {
            "total_comments": 10,
            "total_parent_comments": 10,
            "id": 161318922,
            "username": "posttwo",
            "thumb_direction": 0,
            "text": "Wtf why does police here have guns \nHe's shopping for bread and shir",
            "user_id": 908508,
            "thumb_val": 1,
            "number": 2624150,
            "favorite_id": 0,
            "reply_level": 0,
            "original_avatar_url": null,
            "picture_url": null,
            "thumbnail_url": null,
            "large_image_url": null,
            "width": 0,
            "height": 0,
            "is_sticky": 0,
            "del": 0,
            "comment_flagged": 0,
            "comment_url": "/bulli/2624150#2624150",
            "content": {
                "id": 6074108,
                "web_id": 6074552,
                "type_id": 18,
                "user_id": 1334083,
                "status_id": 4,
                "username": "secretzx",
                "title": "Purecina is cute",
                "description": "░░░░░░░░░░▀▀▀██████▄▄▄░░░░░░░░░░\n░░░░░░░░░░░░░░░░░▀▀▀████▄░░░░░░░\n░░░░░░░░░░▄███████▀░░░▀███▄░░░░░\n░░░░░░░░▄███████▀░░░░░░░▀███▄░░░\n░░░░░░▄████████░░░░░░░░░░░███▄░░\n░░░░░██████████▄░░░░░░░░░░░███▌░\n░░░░░▀█████▀░▀███▄░░░░░░░░░▐███░\n░░░░░░░▀█▀░░░░░▀███▄░░░░░░░▐███░\n░░░░░░░░░░░░░░░░░▀███▄░░░░░███▌░\n░░░░▄██▄░░░░░░░░░░░▀███▄░░▐███░░\n░░▄██████▄░░░░░░░░░░░▀███▄███░░░\n░█████▀▀████▄▄░░░░░░░░▄█████░░░░\n░████▀░░░▀▀█████▄▄▄▄█████████▄░░\n░░▀▀░░░░░░░░░▀▀██████▀▀░░░▀▀██░░",
                "filename": "2a1bd117947ff3f2a299733a0f2f8061.png",
                "filemd5hash2": "2a1bd117947ff3f2a299733a0f2f8061",
                "width": 0,
                "height": 0,
                "thumb_image": "2a1bd1_6074108.png",
                "thumb_image_160x160": "2a1bd1_6074108.png",
                "full_image": "",
                "date": "2016-10-31 18:24:37",
                "tags": null,
                "flagged": 0,
                "flagged_date": null,
                "is_mature": 0,
                "flag_by_admin": null,
                "hot_index": 7642.45,
                "stat_visits": 647698,
                "stat_comments": 2625199,
                "stat_favorited": 1,
                "stat_thumbs_up": 5,
                "stat_thumbs_down": 4,
                "stat_thumbs_weight": 1,
                "allow_comments": 1,
                "ip": "95860d5c952de8ba129525880fc6afdb8aedd05b",
                "channel_id": null,
                "url": "",
                "content_visibility": "default",
                "counted_thumbs_up": 5,
                "counted_thumbs_down": 4,
                "show_ads": 1,
                "visible_to_nonlogged": 1,
                "site": 0,
                "extra_gif": 0,
                "content_country_code": "KP",
                "youtube_start_time": null,
                "repost_content_id": null,
                "visits": 647698,
                "timestamp": 1477938277,
                "dayinterval": 236,
                "channel_name": null,
                "channel_title": null,
                "is_mature_channel": null,
                "default_content_visibility": null
            },
            "user_posted_on": false,
            "reply_id": 0,
            "aspect_ratio": 1,
            "date": "1h ago",
            "type_id": 105,
            "movie_url": null,
            "childs": {
                "1": {
                    "id": 161318927,
                    "username": "argoniantits",
                    "thumb_direction": 0,
                    "text": "terrorists",
                    "user_id": 1268126,
                    "thumb_val": 1,
                    "number": 2624152,
                    "favorite_id": 0,
                    "reply_level": 1,
                    "original_avatar_url": "https://new2.fjcdn.com/avatars/523b37_1268126_big.png",
                    "picture_url": null,
                    "thumbnail_url": null,
                    "large_image_url": null,
                    "width": 0,
                    "height": 0,
                    "is_sticky": 0,
                    "del": 0,
                    "comment_flagged": 0,
                    "reply_id": 2624150,
                    "aspect_ratio": 1,
                    "date": "1h ago",
                    "type_id": 106,
                    "movie_url": null
                }
            },
            "child_count_title": "1 reply",
            "child_count": 1
        },
    "comments_page": 1,
    "total_comments": 47,

Querying getByURL api for /base_content/userComment/908508/2 fails

Deciding to wait for android app to be updated.

thunderysteak commented 7 years ago

How about just doing it the retarded way and automate profile comment page switching using comments.loadUserComments(2);, comments.loadUserComments(3);, and so on with using same kind of content change check that #8 uses so it doesn't end up in a loop after reaching the final page?

posttwo commented 7 years ago

Then you run into the issue I like to call "Indian caching" Depending on the alignment of the planets and the weather on mars, After flagging a page the next one will either be the actual next page, skip a page because cache updated for some reason, not show up at all or repeat previous comments.

Android app should be finished soon...

On Jun 24, 2017 7:11 PM, "thunderysteak" notifications@github.com wrote:

How about just doing it the retarded way and automate profile comment page switching using comments.loadUserComments(2);, comments.loadUserComments(3);, and so on with using same kind of content change check that #8 https://github.com/posttwo/fjmod-extension/issues/8 uses so it doesn't end up in a loop after reaching the final page?

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/posttwo/fjmod-extension/issues/41#issuecomment-310851374, or mute the thread https://github.com/notifications/unsubscribe-auth/AHLSpqACljeSwQ1obN7zgBeVnow-OFZUks5sHUM0gaJpZM4OEWXl .

thunderysteak commented 7 years ago

Then we get even more retarded, because lightning can't strike twice on the same spot.