search

postwait / node-amqp

[UNMAINTAINED] node-amqp is an AMQP client for nodejs
MIT License
1.69k stars 357 forks source link

Remove lodash defaults #249

Closed shernshiou closed 10 years ago

shernshiou commented 11 years ago

I found there is an error where exchange is not calling back after updated to postwait/node-amqp@7c245205646330427b43415556eec4b7697df74e

Therefore I revert line 18 to previous version.

shernshiou commented 11 years ago

Tested using following code

connection.on('ready', function () {
    connection.exchange(exchange_name, { type: 'topic' }, function (exchange) {
      //Not firing here
    });
  });
aheckmann commented 10 years ago

please add the test to this PR.

postwait commented 10 years ago

I can't repeat this. Please resubmit with a test case that fails prior to your change and succeeds afterward your change.