Change channels ids to be compared as strings not numbers

postwait / node-amqp

[UNMAINTAINED] node-amqp is an AMQP client for nodejs

MIT License

1.69k stars 358 forks source link

Change channels ids to be compared as strings not numbers #270

Closed gjohnson closed 10 years ago

gjohnson commented 10 years ago

Change channels ids to be compared as strings since they are stored in an object (self.channels). Not sure if it could possibly fix any known issues related to the "control channel" incorrectly falling into a state of "closed".

aheckmann commented 10 years ago

there is definitely a bug in here waiting to bite at some point without this fix.

gjohnson commented 10 years ago

Once I run into whatever this might effect, I'll post a test case that reproduces it.

postwait commented 10 years ago

Manually cherry-picked.