postwait / node-amqp

[UNMAINTAINED] node-amqp is an AMQP client for nodejs
MIT License
1.69k stars 357 forks source link

Regression of issue #192 #279

Closed thanodnl closed 10 years ago

thanodnl commented 10 years ago

In the latest version published on npmjs the performace degraded heavily compared to version 0.1.4. This is preventing us from using a newer version.

I traced back the performance issues to the debug statements mainly in connection.js and parser.js. It happened to be here in the past as documented in issue #192.

The problem can be solved by testing if you are in debug mode before calling operations like JSON.toString, and toString('hex').

gjohnson commented 10 years ago

This can be closed.