postwait / node-amqp

[UNMAINTAINED] node-amqp is an AMQP client for nodejs
MIT License
1.69k stars 357 forks source link

Disable debugging #283

Closed thanodnl closed 10 years ago

thanodnl commented 10 years ago

This fixes the regression of issue #192 as described in issue #279

postwait commented 10 years ago

I have no particular issues with this change, but unless there is measured speedup, I'm disinclined to take it.

How did you measure speedup and what were your results?

thanodnl commented 10 years ago

I have this script in our app repo which takes messages from queue A and publishes them to queue B before the change the output was:

node test/performance/rbmq.js worker a b Bound queue 'rbmqtest-a' to '#' Running in development mode Processing... Processed 1000 objects in 32873ms (30 per second) Processed 1000 objects in 23739ms (42 per second) Processed 1000 objects in 31317ms (32 per second) Processed 1000 objects in 23106ms (43 per second) Processed 1000 objects in 26902ms (37 per second) Processed 1000 objects in 28750ms (35 per second) Processed 1000 objects in 30068ms (33 per second) Processed 1000 objects in 31784ms (31 per second) Processed 1000 objects in 30519ms (33 per second) Processed 1000 objects in 27663ms (36 per second)

after the change the output was: node test/performance/rbmq.js worker c d Bound queue 'rbmqtest-c' to '#' Running in development mode Processing... Processed 1000 objects in 1314ms (761 per second) Processed 1000 objects in 1220ms (820 per second) Processed 1000 objects in 1155ms (866 per second) Processed 1000 objects in 1589ms (629 per second) Processed 1000 objects in 1172ms (853 per second) Processed 1000 objects in 1382ms (724 per second) Processed 1000 objects in 1053ms (950 per second) Processed 1000 objects in 1320ms (758 per second) Processed 1000 objects in 1102ms (907 per second) Processed 1000 objects in 1231ms (812 per second)

as you see it is almost a 20 fold faster, if you need such a script in your repo to be confident I am willing to make one based on this script.