postwait / node-amqp

[UNMAINTAINED] node-amqp is an AMQP client for nodejs
MIT License
1.69k stars 357 forks source link

add autoDelete as a default exchange option #315

Closed dchankhour closed 10 years ago

postwait commented 10 years ago

We can't change the defaults. That will cause havoc.

dchankhour commented 10 years ago

The issue i was trying to resolve is that i wanted the Default Exchanged to have the autoDelete option set to false which is necessary to make my App behave correctly. But i noticed that the default exchange is always created with autoDelete set to true.

My change does not change the default value, but instead it gives a way of changing the default value if need.

postwait commented 10 years ago

You can specify the autoDelete explicitly if you require a behavior different from the default. Changing defaults in systems make them very hard to reuse and maintain.