search

postwait / node-amqp

[UNMAINTAINED] node-amqp is an AMQP client for nodejs
MIT License
1.69k stars 357 forks source link

node-amqp 0.2.x vs node 0.4 #343

Open albert-lacki opened 10 years ago

albert-lacki commented 10 years ago

Despite package.json statement, node-amqp does not work with node 0.4.x out of the box. The minimal changeset (AFAIK) which must be applied to do so is: https://github.com/albert-lacki/node-amqp/commit/6b092b66b1196acba80884a0f3fbd3dedfd7c111

I suggest either to officially drop support for node 0.4 (not best for me, since I still have some clients with 0.4 :( ), either do some if-then-else magic with process.version or create second "legacy" branch, and publish to npm both with different versions and engines section. It's up to you which is the best. Anyway current package.json information is not correct.

albert-lacki commented 10 years ago

Two more things to be considered to work with node 0.4 https://github.com/albert-lacki/node-amqp/commit/6aa85dd86f6b827939ad4867af1f7383839baf85 https://github.com/albert-lacki/node-amqp/commit/1bfb9eb31845e0bae20deefb3cca942c9c3e96fe

I don't think it's going to be merged ;-)