postwait / node-amqp

[UNMAINTAINED] node-amqp is an AMQP client for nodejs
MIT License
1.69k stars 357 forks source link

Tests failing #387

Open jkondratowicz opened 9 years ago

jkondratowicz commented 9 years ago

I wanted to create a PR with a small fix, but in the process I got stuck on running current set of tests. Most of them fail, even though library works as intended.

Example: test-simple.js. The connection is established successfully, message gets published, consumed and acknowledged. But the test is written in a way that listeners aren't unref-d, so the process doesn't exit when it should (which is after consuming the message). So then the 1s timeout kicks in and throws an exception, which makes the test fail (even though all assertions pass). Is there something about those tests that I misunderstand, or are they just broken?

I'm using version 0.2.4 of node-amqp, 0.12.0 of Node, all under Ubuntu 14.04.