postwait / node-amqp

[UNMAINTAINED] node-amqp is an AMQP client for nodejs
MIT License
1.69k stars 357 forks source link

Reconnecting replaces consumerTag with no ability to hook #447

Closed kfitzgerald closed 7 years ago

kfitzgerald commented 7 years ago

When an error/reconnection occurs, any existing consumers will be replaced with new ones.

If the application is holding a reference to the old tag (e.g. so it can unsubscribe later), its consumer will be replaced with a new one, and has no way of knowing what the new tag is. This is a problem if the consumer wants to unsubscribe after the reconnection event.

I'll submit a PR in a few minutes.

kfitzgerald commented 7 years ago

Fixed in #448