posty / posty_chef

Chef Cookbook for a full Posty Mailserver Installation
www.posty-soft.org
Other
22 stars 8 forks source link

cleanup and minor bugfixing #4

Open alexanderadam opened 8 years ago

alexanderadam commented 8 years ago

Just a few Stylethings fixed, Rakefile added and a travis.yml as well to ensure that at least some code quality checks will be made automatically.

You should change the status url for the badge though if you are going to merge it.

I would love to have at least a few available specs running but they simply don't run. The first attempt failed because the path to the mysql root password was wrong (should also be fixed now) but this time it's an apache issue:

STDERR: Syntax error on line 96 of /etc/apache2/sites-enabled/default-ssl.conf:
Invalid command 'SSLUseStapling', perhaps misspelled or defined by a module not included

That's why I added just a few stylechecks for travis. It would be wonderful if for example a few unit tests would be added (which could be added to the travis task, too).

Anyway, thank you for your work. :wink:

lweis commented 8 years ago

Thank you for the pull requests, we will check as soon as possible

alexanderadam commented 8 years ago

Yay! :tada: