posva / catimg

🦦 Insanely fast image printing in your terminal
http://posva.net/shell/retro/bash/2013/05/27/catimg
MIT License
1.4k stars 57 forks source link

Fix floating point exception #54

Closed boretom closed 4 years ago

boretom commented 4 years ago

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

Other information: Ok, I'm pretty sure I got it this time.

Btw: The floating point will happen with all images, it just depends on the -H value. E.g. catimg -H 80 test-images/mewtwo-front.png also triggers it.

Btw2: I started with a branch where I added simple CMake tests feature/add-simple-tests just in case you're bored. It merged with every branch. Two lines are added to the end of CMakeLists.txt and a new directory test. One can run it by calline ctest after make or make test

posva commented 4 years ago

What test did you add? A visual one?