search

posva / pinia-colada

🍹 The smart data fetching layer for Pinia
https://pinia-colada.esm.dev/
MIT License
761 stars 10 forks source link

feat(use-query): Add enabled option #43

Closed quiteeasy closed 4 months ago

quiteeasy commented 4 months ago

Close #42

I have opened this PR to introduce an 'enable' option for the useQuery feature. This option will allow users to toggle the useQuery refetch/refresh internal behavior on or off based on their requirements.

I have added unit tests to ensure the new option works as expected and I will update the documentation accordingly after merging.

Please review the changes and provide any feedback or suggestions you may have.

netlify[bot] commented 4 months ago

Deploy Preview for funny-banoffee-0afb46 canceled.

Name Link
Latest commit 2f242974bd42010bc0792456670cc27c1355cf08
Latest deploy log https://app.netlify.com/sites/funny-banoffee-0afb46/deploys/6646165376c4560009ad1ed3
quiteeasy commented 4 months ago

Thank you for taking the time to review my pull request. I appreciate the thoughtful feedback you provided. Your suggestions were well-reasoned, and I have implemented the recommended changes.

quiteeasy commented 4 months ago

Should I resolve the threads you created, or would you prefer to do it yourself?

posva commented 4 months ago

Feel free to resolve them. I thought it would be automatic when committing