search

posva / vue-tweezing

💃 Easy, customizable and automatic tweening nicely served in scoped slots
https://posva.net/vue-tweezing
MIT License
99 stars 8 forks source link

adding tween.js delay option support #7

Closed vgshenoy closed 6 years ago

vgshenoy commented 6 years ago

This allows doing things like staggering animations as in this example https://codesandbox.io/s/7w0lww2l40

Not sure if I should run tests for this? Got an error related to localStorage when I tried.

posva commented 6 years ago

Hey! Thanks for this! Tests failing are related to jest. I will update deps and fix it but Yeah, please add a test 😄

posva commented 6 years ago

They are fixed, you should be able to rebase against master now :)

codecov-io commented 6 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files           1        1           
  Lines          70       70           
  Branches       17       17           
=======================================
  Hits           61       61           
  Misses          6        6           
  Partials        3        3
Impacted Files Coverage Δ
src/index.js 87.14% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e23e2ba...0d7d836. Read the comment docs.

vgshenoy commented 6 years ago

Hey @posva , could you please check if this is okay and advise? Unsure if I've gone wrong with

  1. how to include my additions into the code coverage
  2. commits ending up on this pull request 😨
posva commented 6 years ago

Maybe you did a merge 😅 I did a rebase against master and push forced to your branch