search

posva / vuexfire

Check
https://github.com/vuejs/vuefire
MIT License
558 stars 49 forks source link

Firestore #165

Closed R4YM3 closed 6 years ago

R4YM3 commented 6 years ago

// TODO dev check before into if (typeof sub != "function") return

I'm getting errors on the next line, cause sub() is fired which is not a function.

regards

posva commented 6 years ago

Hey, thanks for this, it is not exactly what I meant by that TODO 😄, I wanted to add a dev only warning saying that you called unbind twice on the same ref. This is something I will add during vuefire + vuexfire refactor. If you get the error, it means you're calling unbind when you shouldn't (or it is a bug, in which case I would like you open an issue with a repro, that would really help)

For future PRs, make sure to not commit dist 😛