search

posva / vuexfire

Check
https://github.com/vuejs/vuefire
MIT License
558 stars 49 forks source link

cosmetic changes #199

Closed Obeyed closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #199 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #199   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         101    101           
=====================================
  Hits          101    101
Impacted Files Coverage Δ
src/utils/types.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d6ab13...6590c66. Read the comment docs.

posva commented 5 years ago

Keep in mind vuexfire code is now at https://github.com/vuejs/vuefire/tree/lerna :p

Obeyed commented 5 years ago

Hey, thanks for the quick response! Not entirely sure what the lerna branch is for. Seems like the master branch at vuefire is no longer maintained, or is it just that development is going on at lerna, and later merged into master maybe? You're currently trying to merge vuexfire with vuefire, or are they supposed to be separated? :smile:

posva commented 5 years ago

separated but share code. master is for the old version, lerna for the new one :)