search

potato4d / nuxt-basic-auth-module

Provide basic auth your Nuxt.js application
https://www.npmjs.com/package/nuxt-basic-auth-module
MIT License
311 stars 9 forks source link

"undefined" as enabled option doesn't skip module registration #202

Closed krisimmig closed 2 years ago

krisimmig commented 3 years ago

When giving the "enabled" option "undefined" as value, for example when using ENV variables that are not present on all environments, the module is still activated.

I would propose to change this so that "undefined" also skips the registration. Thoughts? I can make a pull request if this sounds good to everyone.

potato4d commented 2 years ago

I think that's a great suggestion!

krisimmig commented 2 years ago

Ok, I will do this now.